Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set specific awsClusterRoleIdentityName for CAPA test suites #444

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Set specific awsClusterRoleIdentityName for CAPA test suites #444

merged 6 commits into from
Sep 6, 2024

Conversation

ericgraf
Copy link
Contributor

@ericgraf ericgraf commented Aug 21, 2024 •
edited by AverageMarcus
Loading

What this PR does

Towards: https://github.com/giantswarm/giantswarm/issues/29815

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

@ericgraf ericgraf self-assigned this Aug 21, 2024
@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 21, 2024

Note

As this is a draft PR no triggers from the PR body will be handled.

If you'd like to trigger them while draft please add them as a PR comment.

@AverageMarcus AverageMarcus changed the title Set specific awsClusterRoleIdentityName for eks, private and normal e… Set specific awsClusterRoleIdentityName for CAPA test suites Sep 5, 2024
@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

Note

As this is a draft PR no triggers from the PR body will be handled.

If you'd like to trigger them while draft please add them as a PR comment.

@AverageMarcus AverageMarcus requested a review from a team September 5, 2024 10:15
@AverageMarcus AverageMarcus marked this pull request as ready for review September 5, 2024 10:15
@AverageMarcus AverageMarcus requested review from a team as code owners September 5, 2024 10:15
@AverageMarcus
Copy link
Member

/run cluster-test-suites

@AverageMarcus
Copy link
Member

🤦 This is going to fail.

@AverageMarcus
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa,./providers/eks

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suites2pxrs
Commit SHA 859ba57
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@AverageMarcus
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa/private,./providers/capa/cilium-eni-mode

@AverageMarcus
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa/private

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suitesm2ht9
Commit SHA 859ba57
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suitesz426l
Commit SHA 859ba57
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@AverageMarcus
Copy link
Member

COME ON!!!! 😞

/run cluster-test-suites TARGET_SUITES=./providers/capa/private

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suitessl2xk
Commit SHA 859ba57
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@AverageMarcus
Copy link
Member

It turns out the capa private test suite is failing due to a missing IAM permission on the role in the new AWS account. Team Phoenix is assisting with getting it resolved and then I'll re-run the tests to confirm.

@AverageMarcus
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa/private

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suitesdhslb
Commit SHA 77f9689
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@fiunchinho
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa/private

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suites8p5jz
Commit SHA 77f9689
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@fiunchinho
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa/private

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 5, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suites2n2lw
Commit SHA 77f9689
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@AverageMarcus
Updated changelog
c6e946f 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus
Remove team name from value
d804874 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus
Updated readme
076ef42 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus AverageMarcus mentioned this pull request Sep 6, 2024
Closed
@AverageMarcus
Copy link
Member

It looks like the private CAPA WCs don't currently work when deployed into a different AWS account. I've opened an issue for Team Phoenix to investigate and will be removing the change for private WCs from this PR so we can at least have the others isolated.

Issue: giantswarm/roadmap#3671

@AverageMarcus
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa,./providers/eks

@AverageMarcus
Copy link
Member

/run cluster-test-suites TARGET_SUITES=./providers/capa/cilium-eni-mode

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 6, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suitessps9g
Commit SHA bde6f2f
Result Completed ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@AverageMarcus AverageMarcus merged commit 12bc3bf into main Sep 6, 2024
4 checks passed
@AverageMarcus AverageMarcus deleted the add-specific-accounts branch September 6, 2024 14:15
@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 6, 2024

Oh No! 😱 At least one test suite has failed during the AfterSuite cleanup stage and might have left around some resources on the MC!

Be sure to check the full results in Tekton Dashboard to see which test suite has failed and then run the following on the associated MC to list all leftover resources:

PIPELINE_RUN="pr-cluster-test-suites-444-cluster-test-suitesxj5jc"

NAMES="$(kubectl api-resources --verbs list -o name | tr '\n' ,)"
kubectl get "${NAMES:0:${#NAMES}-1}" --show-kind --ignore-not-found -l cicd.giantswarm.io/pipelinerun=${PIPELINE_RUN} -A 2>/dev/null

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 6, 2024

cluster-test-suites

Run name pr-cluster-test-suites-444-cluster-test-suitesxj5jc
Commit SHA bde6f2f
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Gacko Gacko Gacko approved these changes

Assignees

@ericgraf ericgraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericgraf @AverageMarcus @fiunchinho @Gacko @njuettner